[fga] Devx improvements #18574
Merged
[fga] Devx improvements #18574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kill $PID || true | ||
|
|
||
| printf "\nRestarting server and redis to pick up DB changes...\n" | ||
| kubectl rollout restart deployment/server deployment/redis |
There was a problem hiding this comment.
I wonder why we decide to put such longer bash scripts into the leeway yaml? Woudln't it be better to have such scripts written in bash files somewhere and jsut called here (if that is at all necessary)?
There was a problem hiding this comment.
🤷 I don't know. There's not much advantages I can think of, and some downsides.
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some QoL improvements to keep our sanity (probably should have done them last week already 🙈 ):
unblock-user:make-user-admin:fgaRelationshipsVersiongitpod_hostinto all backend checks, to make it easier to target whole preview environments. This is similar to how we do it on the frontend already (source).Summary generated by Copilot
🤖 Generated by Copilot at 1fb0731
This pull request refactors and improves the feature flag management in the
gitpod-protocolandservercomponents using theConfigCatClientclass. It also adds two steps to themake-user-admintask in the./components/BUILD.yamlfile to enable testing the fine-grained access control feature.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold