[bbs] check webhooks permission in scm itself #18575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
akosyakov
reviewed
Aug 22, 2023
|
|
||
| protected hasPermissionToCreateWebhooks(permission: string | undefined) { | ||
| return permission && ["REPO_ADMIN", "PROJECT_ADMIN"].indexOf(permission) !== -1; | ||
| // return true once it can get webhooks, fallback to let SCM itself to check permission |
There was a problem hiding this comment.
where fallback happens?
It seems the code before that we have create permissions, not only read. Is it because it is not so fine grained in bbs?
There was a problem hiding this comment.
@akosyakov We will add webhooks when creating the project. So BBS will go check it as test result shows #18575 (comment)
There was a problem hiding this comment.
Fallback because our permission checking for webhook add is not align to what BBS does
- Admin of BBS has all permission
- Admin can create webhook for all repo/project
- Admin don't have project_admin and repo_admin permission in its open APIs if they don't configure it manually in BBS projects/repos
akosyakov
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 79351cf
Remove webhook permission check for Bitbucket Server prebuilds. This fixes a bug that blocks users from enabling prebuilds on some repositories they have access to. The change affects the file
bitbucket-server-service.ts.Related Issue(s)
Fixes https://linear.app/gitpod/issue/EXP-487
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold