Skip to content

[ws-proxy] Implement graceful shutdown #18583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2023
Merged

[ws-proxy] Implement graceful shutdown #18583

merged 4 commits into from
Aug 28, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 23, 2023

Summary generated by Copilot

🤖 Generated by Copilot at b7bf7f2

This pull request improves the reliability and performance of the workspace proxy by using contexts, goroutines, and graceful shutdowns. It also refactors some code in the cmd and proxy packages to simplify imports and logging.

Related Issue(s)

Fixes ENG-724

How to test

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@aledbf aledbf marked this pull request as ready for review August 26, 2023 14:30
@aledbf aledbf requested a review from a team as a code owner August 26, 2023 14:30
@roboquat roboquat merged commit 5791909 into main Aug 28, 2023
@roboquat roboquat deleted the aledbf/shutdown branch August 28, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants