Skip to content

[ws-manager-mk2] Scrub status fields, add vscode launch.json #18595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Aug 24, 2023

Description

  • Scrub status log fields in ws-manager-mk2 to exclude the ownerToken
  • Configure launch.json and make example config work, used to run mk2 locally with a debugger
  • Remove mk1 (ws-manager) from code-workspace
Summary generated by Copilot

🤖 Generated by Copilot at a61d4b9

This pull request improves the security and privacy of the ws-manager-mk2 component by using the scrubber package to redact sensitive data from logs and outputs. It also updates the example config file and the VS Code settings to reflect the new Workspace CRD and the dependencies of the ws-manager-mk2 component.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@WVerlaek
Copy link
Member Author

WVerlaek commented Aug 25, 2023

Integration tests are faililng, scrubber panics on structs containing unexported fields pointers

The unexported pointer is in a time.Time field nested in the pod status

@WVerlaek
Copy link
Member Author

Fixed, integration tests passing

/unhold

@roboquat roboquat merged commit bf3d548 into main Aug 25, 2023
@roboquat roboquat deleted the wv/mk2-fix-logger branch August 25, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants