Improve gp idp login aws #18601
Merged
Improve gp idp login aws #18601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Aug 25, 2023
| return err | ||
| } | ||
|
|
||
| awsCmd := exec.Command("aws", "sts", "assume-role-with-web-identity", "--role-arn", idpLoginAwsOpts.RoleARN, "--role-session-name", fmt.Sprintf("%s-%d", wsInfo.WorkspaceId, time.Now().Unix()), "--web-identity-token", tkn) |
There was a problem hiding this comment.
@csweichel I'm not familiar, just asking to confirm there is not any breaking changes which would require reconfiguring existing setups on client side
i.e. where role-session-name is used?
There was a problem hiding this comment.
That's not breaking. Sessions usually time out after one hour.
akosyakov
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
approve to unblock
cc @loujaybee if we need to cover any option in some docs
I checked the logs prior to opening this PR. There aren't any flags that would change here. |
|
Docs PR is here: https://github.com/gitpod-io/website/pull/3941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvements to
gp idp login aws:Summary generated by Copilot
🤖 Generated by Copilot at a7d44e1
Simplify and improve
idp-login-awscommand ofgitpod-clitool. Usegitpodpackage,aws configurecommand, andprofileoption. Add workspace ID to role session name.How to test
Start a workspace and use
gp idp login awsDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold