-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update protobufjs lib #18605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobufjs lib #18605
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Any test points? Or we can enable integration test to do smoke tests? Good to see this PR that it will close a ton of issues. It should contains changes on |
Not sure, I asked internally |
@jeanp413, I think it would be good to test workspace events in addition to a simple workspace start:
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6010847186
|
/gh run recreate-vm Comment triggered a workflow runStarted workflow run: 6014207047
|
8353936
to
ef73392
Compare
Works 👍 |
/unhold |
Description
Summary generated by Copilot
🤖 Generated by Copilot at 8353936
Updated
ts-proto
dependency to1.153.0
inide-service-api
andusage-api
components. This fixed a bug related to optional and required fields in TypeScript code generated from protobuf definitions.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled.