Skip to content

Update protobufjs lib #18605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Update protobufjs lib #18605

merged 1 commit into from
Aug 29, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Aug 25, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 8353936

Updated ts-proto dependency to 1.153.0 in ide-service-api and usage-api components. This fixed a bug related to optional and required fields in TypeScript code generated from protobuf definitions.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ts-proto 1.125.0...1.156.7 None +12/-15 106 MB shaberman

@mustard-mh
Copy link
Contributor

Any test points? Or we can enable integration test to do smoke tests? Good to see this PR that it will close a ton of issues.

It should contains changes on ws-manager-bridge and server? Or we did do it other PRs but I don't notice

@jeanp413
Copy link
Member Author

Any test points?

Not sure, I asked internally

@AlexTugarev
Copy link
Member

@jeanp413, I think it would be good to test workspace events in addition to a simple workspace start:

  • have two tabs open on /workspaces
  • in first you can start and later on close a workspace
  • using the second tab, you should be able to monitor updates to the workspace by colors of the status indicator

@AlexTugarev
Copy link
Member

AlexTugarev commented Aug 29, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6010847186

  • recreate_vm: true

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 29, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6014207047

  • recreate_vm: true

@jeanp413
Copy link
Member Author

@jeanp413, I think it would be good to test workspace events in addition to a simple workspace start:

  • have two tabs open on /workspaces
  • in first you can start and later on close a workspace
  • using the second tab, you should be able to monitor updates to the workspace by colors of the status indicator

Works 👍

@jeanp413
Copy link
Member Author

/unhold

@roboquat roboquat merged commit c402032 into main Aug 29, 2023
@roboquat roboquat deleted the jp/key-jackal branch August 29, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants