[image-builder-bob] retry on bad request #18621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
force-pushed
the
kylos101/retry-400
branch
from
234746b to
f9bf9b7
Compare
kylos101
commented
Aug 30, 2023
| @@ -185,6 +185,10 @@ func (proxy *Proxy) reverse(alias string) *httputil.ReverseProxy { | |||
| } | |||
| return true, nil | |||
| } | |||
| if resp.StatusCode == http.StatusBadRequest { | |||
| log.WithField("URL", resp.Request.URL.String()).Warn("bad request") | |||
| return true, nil | |||
There was a problem hiding this comment.
The client is setup to retry up to 3 times. The default wait time in-between retries is 1s. This should help, if we're hitting transient issues that are resulting in bad requests.
Without this change, when we encounter a 400 error, we do not retry, and the image build fails.
iQQBot
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image builds sometimes fail on push due to bad request. Users have reported that they can generally retry again w/o issue. Let's automate the retry as part of bob, to see if it helps avoid transient issues.
The default retry for RetryWaitMin is 1s.
Summary generated by Copilot
🤖 Generated by Copilot at 234746b
Fix a typo and add retry logic in
proxy.go. This enhances the image builder's proxy component.Related Issue(s)
xref: ENG-757
xref: #18611
How to test
Do an image build in preview, https://github.com/kylos101/dotfiles/ is a lovely choice.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold