Allow renaming project #18630
Merged
Allow renaming project #18630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/rename-project
branch
from
d447efd to
ede45e5
Compare
|
Looking at UX changes now! 👀 |
gtsiolis
approved these changes
Sep 1, 2023
| <TextInputField | ||
| hint="The name can be up to 32 characters long." | ||
| value={projectName} | ||
| error={badProjectName} |
There was a problem hiding this comment.
praise: Thanks for adding the validation here! 🐈
| <Heading2>Project Name</Heading2> | ||
| <form onSubmit={updateProjectName}> | ||
| <TextInputField | ||
| hint="The name can be up to 32 characters long." |
There was a problem hiding this comment.
nitpick: Help text look useful, but is needed here all the time? Since we catch this with the validation anyway, thoughts on dropping the help text all together?
akosyakov
reviewed
Sep 4, 2023
| @@ -34,10 +38,30 @@ export default function ProjectSettingsView() { | |||
| const { setProject } = useContext(ProjectContext); | |||
| const { project } = useCurrentProject(); | |||
| const [showRemoveModal, setShowRemoveModal] = useState(false); | |||
| const [projectName, setProjectName] = useState(project?.name || ""); | |||
| let badProjectName = projectName.length > 0 ? undefined : "Project name can not be blank."; | |||
| if (projectName.length > 32) { | |||
There was a problem hiding this comment.
Should not we have it rather on server that it is aligned among all clients? Is it enforced by DB?
akosyakov
approved these changes
Sep 4, 2023
remove project#slug
svenefftinge
force-pushed
the
se/rename-project
branch
from
ede45e5 to
e946fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to rename a project in the prject settings.
Removes the obsolete
Project#slugpropertySummary generated by Copilot
🤖 Generated by Copilot at 94c9882
This pull request removes the
slugfield from the project and team objects and protocols, and replaces it with thenamefield as the primary identifier. This simplifies the project and team models and avoids potential conflicts or inconsistencies with theslugfield. It also adds a feature to the dashboard that allows users to change the project name. It affects several files in the components directory, including TypeScript, Go, and proto files.Related Issue(s)
Fixes EXP-529
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold