fix: change README img link to website #18637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main image in the README (browser-vscode) is large and has `cursor: pointer` on it which makes it more likely that people will have the urge to click it like I did. I expected it to open the website when clicking it, but instead it opens itself on `user-images.githubusercontent` which is pretty pointless. I just wrapped it in an anchor tag that points to the website instead!
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
svenefftinge
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main image in the README (browser-vscode) is large and has
cursor: pointeron it which makes it more likely that people will have the urge to click it like I did.I expected it to open the website when clicking it, but instead it opens itself on
user-images.githubusercontentwhich is pretty pointless.I just wrapped it in an anchor tag that points to the website.
Summary generated by Copilot
🤖 Generated by Copilot at 1567655
This pull request updates the
README.mdfile to make the browser-vscode image a link to the Gitpod website. This change enhances the user experience and invites them to explore Gitpod further.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold