[dashboard] Remove the auto start option #18645

svenefftinge · 2023-09-01T13:57:36Z

Description

This change removes the autostart option on the create workspace page. Instead we always auto start when you come with a contextUrl (unless you use the ?autostart=false query param).

This change also replaces the persistent warning for vscode in the create workspace screen with a toast containing the same information that is shown whenever you select VS Code Desktop (no matter where).

Summary generated by Copilot

`🤖 Generated by Copilot at 91fe550`

This pull request improves the user experience and code quality of the dashboard component, and fixes some TypeScript errors in the usage API component. It adds a toast message for the experimental VS Code for Desktop option, changes the default and visibility of the autostart option, simplifies the workspace creation UI and logic, and removes an unnecessary callback from the workspace mutation hook. It also adds // @ts-ignore comments to the imports of Long in the generated protobuf files.

Related Issue(s)

Fixes #

How to test

Start a workspace using a regular contexURL

https://se-no-autostart.preview.gitpod-dev.com/#https://github.com/svenefftinge/2048-in-terminal
Start one with autoStart=false
https://se-no-autostart.preview.gitpod-dev.com/?autostart=false#https://github.com/svenefftinge/2048-in-terminal
Go to the dashboard and manually start one
https://se-no-autostart.preview.gitpod-dev.com/new

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

🏷️ Name - se-no-autostart
🔗 URL - se-no-autostart.preview.gitpod-dev.com/workspaces.
📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
📦 Version - se-no-autostart-gha.16413
🗒️ Logs - GCP Logs Explorer

Build Options

Build

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer

analytics=segment
with-dedicated-emulation
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
with-monitoring

/hold

jeanp413 · 2023-09-01T15:48:30Z

nit: is it possible to keep track that the same toast is already displayed?

jeanp413 · 2023-09-01T15:51:07Z

Do we need to delete this from user preferences?

jeanp413 · 2023-09-01T15:54:38Z

Doesn't respect setting if workspace is created from a project, steps:

Create workspace from workspace page and select an editor, e.g. vscode desktop
Create a project on the repor you opened in the step above
Open workspace from project page, it will redirect to autostart
🐛 it will open vscode browser by default, but UI says editor is vscode desktop

mbrevoort · 2023-09-01T20:26:27Z

Setting autoStart=false did not prevent the workspace from auto-starting. It is case sensitive and needs to be autostart=false.

loujaybee · 2023-09-02T07:29:04Z

We added the VS Code Desktop warning to elicit feedback when we changed the SSH behaviours. Our primary concern was that it might be unexpected for users that we modify their SSH configuration, so we wanted to be more cautious at first. However as we are only appending, we do add settings to a separate folder, and we append the config update with code comments so the user can easily remove themselves if they want. So far we've not had any negative feedback on that functionality so far. I have also since seen that this is the same approach used in both code catalyst + codesandbox I would suggest it's safe to remove entirely. It is also documented:

https://www.gitpod.io/docs/references/ides-and-editors/vscode#connecting-to-vs-code-desktop

What do you think, Sven? Should we just remove?

CC: @akosyakov / @mustard-mh / @jeanp413 as they were originally involved in the discussions around this feature.

loujaybee · 2023-09-02T07:47:25Z

Thanks for pushing for improvements, Sven 🙏 - I had a think through the different use cases here, and do have some questions about the impact. Since it's a fairly longer comment/discussion I posted on the internal issue to avoid cluttering the PR with comments.

svenefftinge · 2023-09-04T09:41:24Z

Doesn't respect setting if workspace is created from a project, steps: ....
🐛 it will open vscode browser by default, but UI says editor is vscode desktop

I couldn't reproduce this. Can you verify one more?

jeanp413 · 2023-09-04T15:41:35Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6075466411

recreate_vm: true

jeanp413 · 2023-09-04T16:16:43Z

Still there 🐛

selfcontained · 2023-09-14T15:28:51Z

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6187648378

recreate_vm: true

selfcontained

If I pick a repo on the new workspace page it updates the hash to track that selected state. If I then reload the page, it auto-starts. I don't think we want that behavior, but that would mean we can't rely on a context url in the hash being present to trigger auto starting.

selfcontained · 2023-09-14T15:20:03Z

components/dashboard/src/data/workspaces/create-workspace-mutation.ts

-            if (result && result.createdWorkspaceId) {
-                // successfully started a workspace, wait a bit before we allow to start another one
-                setTimeout(() => {
-                    setIsStarting(false);


Seems like isStarting will remain true now even after it's done. Maybe we can just use the isLoading state now instead - isStarting: mutation.isLoading?

geropl · 2023-09-18T09:16:51Z

What's the current state with this PR? Can we close it (for now)?

svenefftinge · 2023-09-18T09:40:49Z

I'll continue and merge when the nee browser extension is out

svenefftinge requested a review from a team as a code owner September 1, 2023 13:57

roboquat added do-not-merge/hold size/L labels Sep 1, 2023

github-actions bot added the team: team-experience label Sep 1, 2023

svenefftinge added 2 commits September 4, 2023 09:43

[usage-api] shutup compiler

8bf5797

[dashboard] simplify autostart

66b5e67

svenefftinge force-pushed the se/no-autostart branch from 91fe550 to 66b5e67 Compare September 4, 2023 09:44

selfcontained reviewed Sep 14, 2023

View reviewed changes

svenefftinge closed this Sep 25, 2023

svenefftinge deleted the se/no-autostart branch September 25, 2023 15:01

mustard-mh mentioned this pull request Nov 29, 2023

[papi] Add UserService/UpdateUser to proto #19163

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dashboard] Remove the auto start option #18645

[dashboard] Remove the auto start option #18645

Uh oh!

svenefftinge commented Sep 1, 2023 •

edited by github-actions bot

Loading

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

mbrevoort commented Sep 1, 2023

Uh oh!

loujaybee commented Sep 2, 2023

Uh oh!

loujaybee commented Sep 2, 2023

Uh oh!

svenefftinge commented Sep 4, 2023

Uh oh!

jeanp413 commented Sep 4, 2023 •

edited by github-actions bot

Loading

Uh oh!

jeanp413 commented Sep 4, 2023

Uh oh!

selfcontained commented Sep 14, 2023 •

edited by github-actions bot

Loading

Uh oh!

selfcontained left a comment

Uh oh!

selfcontained Sep 14, 2023

Uh oh!

geropl commented Sep 18, 2023

Uh oh!

svenefftinge commented Sep 18, 2023

Uh oh!

Uh oh!

[dashboard] Remove the auto start option #18645

[dashboard] Remove the auto start option #18645

Uh oh!

Conversation

svenefftinge commented Sep 1, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

🤖 Generated by Copilot at 91fe550

Related Issue(s)

How to test

Documentation

Preview status

Build Options

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

jeanp413 commented Sep 1, 2023

Uh oh!

mbrevoort commented Sep 1, 2023

Uh oh!

loujaybee commented Sep 2, 2023

Uh oh!

loujaybee commented Sep 2, 2023

Uh oh!

svenefftinge commented Sep 4, 2023

Uh oh!

jeanp413 commented Sep 4, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

jeanp413 commented Sep 4, 2023

Uh oh!

selfcontained commented Sep 14, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment triggered a workflow run

Uh oh!

selfcontained left a comment

Choose a reason for hiding this comment

Uh oh!

selfcontained Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

geropl commented Sep 18, 2023

Uh oh!

svenefftinge commented Sep 18, 2023

Uh oh!

Uh oh!

svenefftinge commented Sep 1, 2023 •

edited by github-actions bot

Loading

`🤖 Generated by Copilot at 91fe550`

jeanp413 commented Sep 4, 2023 •

edited by github-actions bot

Loading

selfcontained commented Sep 14, 2023 •

edited by github-actions bot

Loading