Filter subscriber reconciler events #18660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/hold
do-not-merge/work-in-progress
size/S
size/M
and removed
size/S
labels
aledbf
force-pushed
the
aledbf/fiilter
branch
from
fe55de2 to
2b907a6
Compare
WVerlaek
reviewed
Sep 6, 2023
Comment on lines
+91
to
+93
| if !cmp.Equal(old.Spec.Ports, new.Spec.Ports) { | ||
| return true | ||
| } |
There was a problem hiding this comment.
what's the reason for doing the special comparison on ports? Should we do this comparison on the entire spec instead? E.g. there's the workspace timeout values in the spec that can change as well
There was a problem hiding this comment.
Only the failure to compare Ports introduce errors in the integration tests (changing the visibility requires a notification)
aledbf
force-pushed
the
aledbf/fiilter
branch
from
c3feef5 to
9cb2f4b
Compare
aledbf
force-pushed
the
aledbf/fiilter
branch
from
9cb2f4b to
d72b240
Compare
WVerlaek
approved these changes
Sep 6, 2023
roboquat
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the number of events sent to subscribers to those that change the status of the workspace.
(by half during workspace creation)
Summary generated by Copilot
🤖 Generated by Copilot at a4315da
Improve subscriber controller efficiency by filtering workspace status changes. Add new packages and a filter function to
subscriber_controller.go.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold