Fix undefined user causes <Login> to be renderd

[AlexTugarev]

This is a partial revert of https://github.com/gitpod-io/gitpod/pull/18644/files#diff-9e9eff78ab3659985873f20c06939bb2c211067b026b5fb21f5a7e6dc7ffc2c2R49

Description

This fixes an issue I introduced a short while ago by following a suggestion on the deprecation note of onSuccess of react-query. For a fraction of a second the Login component is rendered, as the cycle to update the User state (captured in context) is too long query.isLoading changes to false earlier.

Summary generated by Copilot

🤖 Generated by Copilot at 8f1e445

Improved the performance and reliability of the useUserLoader hook and cleaned up the code.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

• 🏷️ Name - at-fix-user-loading
• 🔗 URL - at-fix-user-loading.preview.gitpod-dev.com/workspaces.
• 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
• 📦 Version - at-fix-user-loading-gha.16586
• 🗒️ Logs - GCP Logs Explorer

Build Options

Build

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer

• analytics=segment
• with-dedicated-emulation
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
• with-monitoring

[geropl]

Code LGTM, tested and don't see the flashing "loading"-state anymore ✔️