Skip to content

Update VS Code Browser to 1.82.0 #18680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Update VS Code Browser to 1.82.0 #18680

merged 4 commits into from
Sep 8, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Sep 7, 2023

Description

Update code to 1.82.0

Progress

How to test

  • Switch to VS Code Browser Insiders in settings.
  • Start a workspace.
  • Test the following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod
    • that a PR view is preloaded when opening a PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data like vscode_extension_gallery is collected in Segment

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 7, 2023

terminals are preserved and resized properly between window reloads

This seems it's a regression, size is not preserved
Update: I can repro in vscode desktop too

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 8, 2023

This seems it's a regression, size is not preserved

Fixed

@mustard-mh
Copy link
Contributor

mustard-mh commented Sep 8, 2023

Open with Desktop with macOS
image

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 8, 2023

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6124263440

  • recreate_vm: true

@roboquat roboquat merged commit bef25a6 into main Sep 8, 2023
@roboquat roboquat deleted the jp/sacred-canidae branch September 8, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants