Skip to content

[fga] fix workspace sharing #18685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2023
Merged

[fga] fix workspace sharing #18685

merged 1 commit into from
Sep 8, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Sep 8, 2023

Description

We must not try to fetch the team members if the user is FGA enabled, ebcause this might be a shared workspace, where the user has access to the workspace but not to the org.

Summary generated by Copilot

🤖 Generated by Copilot at aade32f

Use feature flag to enable fine-grained access control for workspaces. Refactor gitpod-server-impl.ts to avoid unnecessary queries for team members.

Related Issue(s)

Fixes EXP-588

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Code LGTM, ✔️ to unblock

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 573f3cc into main Sep 8, 2023
@roboquat roboquat deleted the se/fga-ws-share branch September 8, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants