Skip to content

Change issuer identifier address for OIDC #18693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Change issuer identifier address for OIDC #18693

merged 2 commits into from
Sep 18, 2023

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Sep 11, 2023

Description

Configure Gitpod Cloud to use services.gitpod.io instead of api.gitpod.io for IDP tokens.

We have communicated to users that this breaking change will take effect on 18 September 2023. We will need to make sure this is only rolled out on that day. cc @akosyakov @loujaybee

Summary generated by Copilot

🤖 Generated by Copilot at 0a6c4b8

Refactor public API server to use services subdomain. Update publicUrl variable in configmap.go to reflect this change.

Related Issue(s)

Relates #ENG-542

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@easyCZ
Copy link
Member

easyCZ commented Sep 11, 2023

Pushed a fix for unit tests

@easyCZ
Copy link
Member

easyCZ commented Sep 11, 2023

Screenshot 2023-09-11 at 13 52 51 Can confirm the change works

@laushinka
Copy link
Contributor Author

Can confirm the change works

Thank you!

Keeping this on hold until rollout for 18 September 2023.

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblock from exp

@roboquat roboquat merged commit 4ac15c7 into main Sep 18, 2023
@roboquat roboquat deleted the lm/oidc-change branch September 18, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants