Skip to content

Fix rendering of ProjectListItem #18721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix rendering of ProjectListItem #18721

merged 1 commit into from
Sep 15, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 15, 2023

Becauser of the public-api.ts conversion, it can render prebuilds disables if not set in settings.

Description

Summary generated by Copilot

🤖 Generated by Copilot at e5b0195

Refactor enablePrebuilds logic to use a helper function in ProjectListItem.tsx and Project.ts. This improves code readability and maintainability.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Becauser of the public-api.ts conversion, it can render prebuilds disables if not set in settings.
@AlexTugarev
Copy link
Member Author

/unhold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@roboquat roboquat merged commit d053e39 into main Sep 15, 2023
@roboquat roboquat deleted the at/fix-project-list-item branch September 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants