Skip to content

Fix PAPI conversion #18722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix PAPI conversion #18722

merged 1 commit into from
Sep 15, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 15, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 99bc2de

This pull request updates the projects API to make the enable_prebuilds field of the PrebuildSettings message optional. This allows users to configure prebuilds for their projects without specifying a boolean value, and to inherit the default settings from the team or the global configuration. The pull request modifies the proto, Go, and TypeScript definitions of the message and the related types.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@AlexTugarev
Copy link
Member Author

Screenshot 2023-09-15 at 12 14 47 Screenshot 2023-09-15 at 12 14 51 Screenshot 2023-09-15 at 12 14 57

@geropl, just verified that it's behaving as expected.

@AlexTugarev
Copy link
Member Author

/hold

@AlexTugarev
Copy link
Member Author

/unhold

@AlexTugarev AlexTugarev reopened this Sep 15, 2023
@roboquat roboquat merged commit 8d4128b into main Sep 15, 2023
@roboquat roboquat deleted the at/fix-papi-convert branch September 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants