Skip to content

[spicedb] Grant all org members project "editor" role #18733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 18, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 9a1555d

This pull request refactors the project authorization logic to use SpiceDB and permissions instead of relations. It removes the editor relation from the ProjectRelation type and adds it to the ProjectPermission type. It also updates the project settings and tests to reflect the new logic and allow more actions for project members. It modifies the files components/server/src/authorization/definitions.ts, components/server/src/projects/projects-service.spec.db.ts, components/server/src/user/env-var-service.spec.db.ts, and components/spicedb/schema/schema.yaml.

Related Issue(s)

Fixes EXP-608

How to test

  • user 1: create an org
  • user 2: join with that org (as member)
  • user 2: create a project
  • user 2: change settings on that project ✔️
  • user 2: add/modify/remove env vars on that project ✔️

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member Author

geropl commented Sep 18, 2023

/unhold

@roboquat roboquat merged commit 6552fd5 into main Sep 18, 2023
@roboquat roboquat deleted the gpl/rm-project-editor branch September 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants