Skip to content

[ubp] Improve logging when checking hasPaidSubscription #18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 19, 2023

Description

The UnhandledPromiseRejections generated by the old code came up quite a lot but lagged detail so it was not clear what exactly caused them. The explicit warn() should fix that.

Summary generated by Copilot

🤖 Generated by Copilot at 0fd1b87

Improve error handling and logging in EntitlementServiceUBP. Prevent invalid or unauthorized IDs from affecting subscription checks.

Related Issue(s)

Fixes EXP-645

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member Author

geropl commented Sep 19, 2023

/unhold

@roboquat roboquat merged commit 1c5087b into main Sep 19, 2023
@roboquat roboquat deleted the gpl/fix-upe branch September 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants