Skip to content

[db] DBPrebuiltWorkspace: Add index ind_creationTime #18818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 27, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 4a35e53

This pull request adds an index on the creationTime column of the DBPrebuiltWorkspace table to improve the performance of prebuild queries. It also adds a migration file to create or drop the index in the database schema.

Related Issue(s)

Fixes EXP-710

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl marked this pull request as ready for review September 27, 2023 08:30
@geropl geropl requested a review from a team as a code owner September 27, 2023 08:30
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I'm curious about why we should write migration down for index adding?

@geropl
Copy link
Member Author

geropl commented Sep 27, 2023

But I'm curious about why we should write migration down for index adding?

IMO in general we should go with the habbit of adding down implementations. But you are right, we are not making proper use of them, yet. 👍

@geropl
Copy link
Member Author

geropl commented Sep 27, 2023

/unhold

@roboquat roboquat merged commit f617ea2 into main Sep 27, 2023
@roboquat roboquat deleted the gpl/710-count-pws branch September 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants