-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adding searchRepositories jsonrpc method #18827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
216dc01
to
b5e789f
Compare
log.warn(logCtx, "Error searching user repos", err); | ||
}); | ||
|
||
// TODO: Look at using graphql query to grab all orgs w/ some kind of latest activity date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan on doing this before we'd enable the flag, but wanted to start getting feedback sooner. This may be grabbing orgs that aren't necessarily relevant w/ recent activity. I anticipate we'll have similar challenges w/ other scm providers, so can look at it at the same time.
.run(user, async (api) => { | ||
return api.orgs.listMembershipsForAuthenticatedUser({ | ||
state: "active", | ||
per_page: 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to find a repo that I have access to but couldn't find it. Probably because it is not among those 5 orgs. Would it be to slow to search all orgs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we aim to already provide the "active" repositories with the other query that doesn't pass in a search, I believe this one should rather be complete in what I can find and could compromise a bit (if not too much) on performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah I agree. I'll play around with it a bit more.
/unhold |
Description
Adds a new
searchRepositories()
method to server to assist in enhancing the repo selector for creating new workspaces/projects that searches across scm providers. It then integrates that call into the<RepositoryFinder/>
component used on the create workspace page.The feature is behind a new flag,
repositoryFinderSearch
, which is only on in non-prod.Summary generated by Copilot
🤖 Generated by Copilot at 558dbf7
Added a new API method
searchRepositories
to theGitpodServer
interface and implemented it for theGitpodServerImpl
class. Added stub or working implementations of thesearchRepos
method to the variousRepositoryProvider
classes for different repohosts. The purpose of these changes is to enable a repository search feature for workspace creation.Related Issue(s)
Fixes EXP-729
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold