Fix compatibility issues with db-migration #18831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
Sep 28, 2023
| @@ -10,22 +10,22 @@ import { columnExists } from "./helper/helper"; | |||
| export class CodeSyncDropDeleted1695733993909 implements MigrationInterface { | |||
| public async up(queryRunner: QueryRunner): Promise<void> { | |||
| if (await columnExists(queryRunner, "d_b_code_sync_resource", "deleted")) { | |||
| await queryRunner.query("ALTER TABLE `d_b_code_sync_resource` DROP COLUMN `deleted`, ALGORITHM=INSTANT"); | |||
| await queryRunner.query("ALTER TABLE `d_b_code_sync_resource` DROP COLUMN `deleted`"); | |||
There was a problem hiding this comment.
It would make sense to use ALGORITHM=INPLACE, LOCK=NONE here, as it's quite a lot of data. Using this is a proven pattern with v5.7 and docs on v8 still show support.
There was a problem hiding this comment.
We already finish migration, so it's won't affect us, dedicated user don't have large data, so I think it's fine
AlexTugarev
approved these changes
Sep 28, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compatibility issues with db-migration by removing
ALGORITHM=INSTANTFor MySQL 8.0, this is the default option. Adding it will cause DML statements that don't support instant updates to fail immediately.
For MySQL 5.7, it doesn't support this, so removing is safe.
Summary generated by Copilot
copilot: summary
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold