Skip to content

[dashboard] remember options per repo #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[dashboard] remember options per repo #18835

merged 1 commit into from
Sep 28, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Sep 28, 2023

Description

This change removes the autoStartOptions-checkbox from the create workspace page and instead relies on the n autostart param for immediately creating the workspace.
It also makes the page always remember the last used options per repo.

Summary generated by Copilot

🤖 Generated by Copilot at c21eae9

This pull request simplifies the user experience of customizing workspace options by removing the RememberOptions checkbox and renaming autostart options to workspace options. It also improves the error handling and feedback for users who need to authorize Git providers on the preferences page. It affects the files Preferences.tsx and CreateWorkspacePage.tsx in the dashboard component.

Related Issue(s)

Fixes EXP-695

How to test

  • go to the new/ page and verify there is no autostart section anymore
  • change something in the options and start a workspace
  • start another workspace on the same repo and verify the previously selected options are used.
  • check autostart=true actually autostarts

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member

geropl commented Sep 28, 2023

Code LGTM on first glance, waiting for the preview 👀

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected ✔️

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit ead0ba0 into main Sep 28, 2023
@roboquat roboquat deleted the se/autostart branch September 28, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants