Use User.fgaRelationshipsVersion instead of User.additionalAttributes.fgaRelationshipsVersion #18838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svenefftinge The related query turned up #3 on Monday while FGA was on. This PR just creates a new column and uses that, which is ok I thought because of the version 3 migration that has to be done anyway (saves us the migration + another deployment). WDYT? |
svenefftinge
approved these changes
Sep 28, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be able to add indexes, and separate concerns.
Summary generated by Copilot
🤖 Generated by Copilot at 141a7cc
This pull request implements the FGA migration, which moves the FGA version from the
additionalDatafield to a separate column in thed_b_usertable. It updates the user data model, the database schema and migrations, the user database service and its tests, the relationship updater and its tests, and the user controller and service. It also fixes a typo in an unrelated migration.Related Issue(s)
Fixes EXP-726
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold