Skip to content

[test] Fix parallel limiter unlocking before ws stopped #18839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

WVerlaek
Copy link
Member

@WVerlaek WVerlaek commented Sep 28, 2023

Description

Fix parallel limiter sometimes unlocking the limiter before a workspace has stopped (when waitForStop is false). This could allow more than the max amount of parallel workspaces to be started (4), causing the test(s) to fail.

Summary generated by Copilot

🤖 Generated by Copilot at 57df844

Refactor the workspace stopping function in the integration test package. Improve error handling and logging for stopWsF in workspace.go.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@WVerlaek
Copy link
Member Author

@WVerlaek
Copy link
Member Author

/unhold

@roboquat roboquat merged commit a5afbd2 into main Sep 28, 2023
@roboquat roboquat deleted the wv/fix-e2e-parallel-limiter branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants