Skip to content

Upgrade VS Code stale to pick up WS fixes for FF. #18843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 29, 2023

Description

Upgrade VS Code stale to pick up WS fixes for FF.

Summary generated by Copilot

🤖 Generated by Copilot at 9205b24

Update JetBrains IDE plugin to the latest version. This pull request brings the main branch up to date with the release branch that contains the updated codeCommit and codeVersion fields in WORKSPACE.yaml.

Related Issue(s)

Fixes EXP-666

How to test

Using stable VS Code test toggling tailscale exit nodes with Chrome and FireFox. In both cases web sockets to VS Code Server should not be reconnected and VS Code should stay functional, e.g. terminals, file explorer, language smartness, etc.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@akosyakov akosyakov marked this pull request as ready for review September 29, 2023 09:00
@akosyakov akosyakov requested a review from a team as a code owner September 29, 2023 09:00
@akosyakov akosyakov changed the title update code commit Upgrade VS Code stale to pick up WS fixes for FF. Sep 29, 2023
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@akosyakov
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 1325935 into main Sep 29, 2023
@roboquat roboquat deleted the ak/fix_ff_stable branch September 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants