Skip to content

Increase getSuggestedRepositories client cache to 7 days #18855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Oct 2, 2023

Description

This is a change to help improve some of the usability around creating a workspace.

Increases the cacheTime for the getSuggestedRepositories call from 1 day to 7 days. This will keep the result in cache for up to a week which will help reduce the chance of not having any data after a weekend. New data will still get loaded when the user visits the create workspace page, but it won't get hung up waiting for an initial result from getSuggestedRepositories and will use the data in cache.

Summary generated by Copilot

🤖 Generated by Copilot at f96db25

Increased the cache time for the suggested-repositories-query to reduce API calls and improve dashboard performance. This was part of a pull request to optimize the dashboard loading time and user experience.

How to test

  • Verify create workspace loads your suggested repositories on initial load.
  • Refresh the page and it shouldn't block on loading them.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@selfcontained selfcontained marked this pull request as ready for review October 2, 2023 18:45
@selfcontained selfcontained requested a review from a team as a code owner October 2, 2023 18:45
@selfcontained selfcontained changed the title increase to 7 days Increase getSuggestedRepositories client cache to 7 days Oct 2, 2023
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 4abea1c into main Oct 2, 2023
@roboquat roboquat deleted the brad/suggested-repos-query-cache-bump branch October 2, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants