Skip to content

[code] Cleanup unused replace rules #18888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[code] Cleanup unused replace rules #18888

merged 1 commit into from
Oct 9, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Oct 7, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at cc09d2c

This pull request simplifies the code and configuration of the codehelper and blobserve components, which are responsible for serving the VS Code web server to the IDE. It removes some unnecessary logic and variables that were used to customize the Open VSX registry URL, which is now handled by blobserve alone.

How to test

  • Check vscode web works, webviews, web extension, gp validate, etc

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@akosyakov
Copy link
Member

Web extensions are still pulling from open-vsx.org, but it is known right?

Screenshot 2023-10-09 at 09 32 22

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jeanp413
Copy link
Member Author

jeanp413 commented Oct 9, 2023

Web extensions are still pulling from open-vsx.org, but it is known right?

yep

@roboquat roboquat merged commit 14d20ce into main Oct 9, 2023
@roboquat roboquat deleted the jp/managing-skunk branch October 9, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants