remove supervisor_live_git_status #18921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/always_live_git_status
branch
from
027403c to
6de97c5
Compare
akosyakov
commented
Oct 13, 2023
|
Code LGTM, waiting for the preview. |
and deprecated instance.status.repo
akosyakov
force-pushed
the
ak/always_live_git_status
branch
from
6de97c5 to
5ecc217
Compare
|
/gh run recreate-vm=true Comment triggered a workflow runStarted workflow run: 6530360668
|
|
@geropl I tested it. |
|
Testing now... |
geropl
approved these changes
Oct 16, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We deployed live git status in all installations for some time already. This PR removes supervisor_live_git_status and deprecated instance.status.repo.
This PR does not remove though status capture by ws-manager on stop.
Summary generated by Copilot
🤖 Generated by Copilot at 027403c
This pull request removes the deprecated and unused code related to the
repoproperty and thesupervisor_live_git_statusfeature flag from various components and files. It also simplifies the usage of thegitStatusproperty to reflect the live git status of the workspace instances.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold