Setup podkit folder and move Combobox into it #18923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Podkit
Sets up a new
podkit
directory in dashboard components meant to start housing components that are built on radix-ui primitives and meet a certain level of accessibility and design standards as well as being generic/decoupled enough to use across any UI surface we build (web/desktop clients). We plan on filling this out more by refactoring our existing components into this pattern as we have opportunities.Eventually we can see opportunity to encapsulate this component library into it's own package in our monorepo, but for now we'll start w/ it in our dashboard components since that's the primary consumer.
I've refactored our
Dropdown2
component into aCombobox
component as the first step. I've also incorporate lucide icons that we should use for any components in the podkit directory vs. the one-off svg files we currently rely on. This should also help us w/ consistency and move quicker when building out new components that rely on iconography.Screen.Recording.2023-10-13.at.2.13.35.PM.mov
Summary generated by Copilot
🤖 Generated by Copilot at 7dd60e2
Refactor dashboard components to use
Combobox
component frompodkit
library instead ofDropDown2
component. Replace custom icons withlucide-react
icons. Improve UI consistency, accessibility, and responsiveness of the dashboard. Updatetailwind.config.js
to add custom animation classes.How to test
Take a look at the UI that uses Combobox and verify it looks right still.
There's a few new treats in this component:
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold