Skip to content

Increase project name max length #18941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Increase project name max length #18941

merged 3 commits into from
Oct 18, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Oct 17, 2023

Description

Increase project name max length to 100 chars, max db value is 255.

Summary generated by Copilot

🤖 Generated by Copilot at 6f2ff58

Refactor project name length validation and hint text to use a constant value of MAX_PROJECT_NAME_LENGTH. This affects the files ProjectSettings.tsx and projects-service.ts in the dashboard and server components respectively.

Related Issue(s)

Fixes https://linear.app/gitpod/issue/CUS-153

How to test

  • Create a project with a long name

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/M and removed size/S labels Oct 17, 2023
@jeanp413 jeanp413 marked this pull request as ready for review October 17, 2023 18:49
@jeanp413 jeanp413 requested a review from a team as a code owner October 17, 2023 18:49
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior and code LGTM
image

Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - verified we truncate in the few places it shows up. 100 is a bit more than we show anywhere, but seems like an ok constraint, and we can always adjust our ui to show more if we want to.

@roboquat roboquat merged commit b70e746 into main Oct 18, 2023
@roboquat roboquat deleted the jp/ruling-zebra branch October 18, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants