[GRPC] Organization API #18948
Merged
[GRPC] Organization API #18948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/org-api
branch
4 times, most recently
from
3db0be3 to
8c41b80
Compare
akosyakov
reviewed
Oct 18, 2023
akosyakov
reviewed
Oct 18, 2023
components/dashboard/src/service/json-rpc-organization-client.ts
Outdated
Show resolved
Hide resolved
akosyakov
reviewed
Oct 18, 2023
components/dashboard/src/service/json-rpc-organization-client.ts
Outdated
Show resolved
Hide resolved
akosyakov
approved these changes
Oct 18, 2023
geropl
reviewed
Oct 19, 2023
components/public-api/gitpod/experimental/v2/organization.proto
Outdated
Show resolved
Hide resolved
geropl
reviewed
Oct 19, 2023
geropl
reviewed
Oct 19, 2023
| context: HandlerContext, | ||
| ): Promise<CreateOrganizationResponse> { | ||
| const org = await this.orgService.createOrganization(context.user.id, req.name); | ||
| const response = new CreateOrganizationResponse(); |
There was a problem hiding this comment.
Love the conciseness and single-purpose of this method 🧡 😄
svenefftinge
force-pushed
the
se/org-api
branch
2 times, most recently
from
a6ce3dd to
56eb228
Compare
svenefftinge
force-pushed
the
se/org-api
branch
from
56eb228 to
deaa923
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines and implements an organization API
Summary generated by Copilot
🤖 Generated by Copilot at 4bac2d4
This pull request introduces and uses the new public API for workspaces and organizations, which is based on the Connect protocol and the experimental v2 services. It refactors the dashboard and the gitpod-protocol components to use the public API types and clients, and updates the proxy and the test configuration accordingly. It also adds some helper functions and converters to facilitate the communication and conversion between the public API and the legacy JSON-RPC types.
Related Issue(s)
Fixes EXP-821
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold