fix JWT verification #18957
Merged
fix JWT verification #18957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
reviewed
Oct 19, 2023
| @@ -113,7 +113,7 @@ export class SessionHandler { | |||
| if (!subject) { | |||
| throw new Error("Subject is missing from JWT session claims"); | |||
| } | |||
| return await this.userService.findUserById(claims.subject, claims.subject); | |||
There was a problem hiding this comment.
Should we check userId if it's correct uuid inside function too
There was a problem hiding this comment.
yeah, I think we need add more guards and tests afterwards, but we need to fix state on main too
mustard-mh
approved these changes
Oct 19, 2023
|
/unhold |
akosyakov
added a commit
that referenced
this pull request
Oct 19, 2023
This reverts commit 90c3541.
roboquat
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 5f331ca
Refactor session handling logic in
servercomponent. Simplify code by reusingsubjectvariable insession-handler.ts.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold