[db] userById fails on undefined #18962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
Oct 20, 2023
| @@ -49,6 +49,7 @@ import { log } from "@gitpod/gitpod-protocol/lib/util/logging"; | |||
| import { DataCache } from "../data-cache"; | |||
| import { TransactionalDBImpl } from "./transactional-db-impl"; | |||
| import { TypeORM } from "./typeorm"; | |||
| import { ApplicationError, ErrorCodes } from "@gitpod/gitpod-protocol/lib/messaging/error"; | |||
There was a problem hiding this comment.
seems odd to me to use messaging errors in db layer, but the check is good.
akosyakov
approved these changes
Oct 20, 2023
svenefftinge
force-pushed
the
se/db-userbyid
branch
from
37b86bc to
a6e31f0
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make findUserById fail on
undefined.Summary generated by Copilot
🤖 Generated by Copilot at a6e31f0
This pull request improves the error handling and testing of the
findUserByIdmethod in the user database module. It adds custom errors using theApplicationErrorclass and two new test cases inuser-db.spec.db.ts.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold