Skip to content

[a11y] User setting Git providers 📱 improvement #18978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2023
Merged

[a11y] User setting Git providers 📱 improvement #18978

merged 1 commit into from
Oct 28, 2023

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Oct 27, 2023 •
edited
Loading

Description

Accessibility improvement for mobile/tablet on Git providers User settings modal.

Before After
image image

Preview on iPhone 14 plus

Summary generated by Copilot

🤖 Generated by Copilot at 3b4ffdd

Added md:flex-grow class to modal body in Modal.tsx to improve responsiveness. This is part of a pull request to make the dashboard more mobile-friendly.

Related Issue(s)

Fixes WEB-464

How to test

  • Open preview url and Go to /user/integrations.
  • Open in Mobile view using Browser DevTools.
  • Click on three vertical dots next to Git provider name
  • Click on Edit Permissions
  • See accesible button for Update Permissions

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@Siddhant-K-code Siddhant-K-code requested a review from a team as a code owner October 27, 2023 18:53
filiptronicek
filiptronicek approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, code looks good :shipit:

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit c581b09 into main Oct 28, 2023
@roboquat roboquat deleted the fix/WEB-464 branch October 28, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
aspect: accessibility size/XS team: team-experience user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siddhant-K-code @filiptronicek @roboquat