Skip to content

Add throughput condition #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add throughput condition #18982

merged 1 commit into from
Oct 30, 2023

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Oct 30, 2023

Description

Add throughput condition that records when throughput of volumes has been adjusted.

Summary generated by Copilot

🤖 Generated by Copilot at 1e08db4

Add a new workspace condition ThroughputAdjusted to the ws-manager-api CRD. This condition signals when the volume throughput of a workspace is dynamically adjusted by the ws-manager.

Related Issue(s)

Fixes ENG-1006

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT: Had a quick look at the PR that needs this.

@roboquat roboquat merged commit 17f7b6c into main Oct 30, 2023
@roboquat roboquat deleted the fo/adjust-throughput branch October 30, 2023 11:00
Furisto added a commit that referenced this pull request Oct 31, 2023
csweichel pushed a commit that referenced this pull request Nov 9, 2023
csweichel pushed a commit that referenced this pull request Nov 9, 2023
roboquat pushed a commit that referenced this pull request Nov 9, 2023
* Adding volume fields to workspace CRs

* Move workspace volume details to status

* Add VolumeAttachRequest condition

* Add throughput condition (#18982)

---------

Co-authored-by: Alejandro de Brito Fontes <[email protected]>
Co-authored-by: Thomas Schubart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants