Only show privacy policy notice on Gitpod Cloud #18985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good (from preview environment) |
| @@ -74,7 +74,7 @@ export class UserService { | |||
| } | |||
| if (newUser.additionalData) { | |||
| // When a user is created, it does not have `additionalData.profile` set, so it's ok to rewrite it here. | |||
| newUser.additionalData.profile = { acceptedPrivacyPolicyDate: new Date().toISOString() }; | |||
| // todo:revert newUser.additionalData.profile = { acceptedPrivacyPolicyDate: new Date().toISOString() }; | |||
There was a problem hiding this comment.
what should I do with this todo? Revert immediately?
There was a problem hiding this comment.
Also wouldn't new users get the notification now as well, because seeing the terms during signup is not recorded?
svenefftinge
approved these changes
Oct 31, 2023
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the Updated privacy policy alert to be more flexible, and only show for users on Gitpod Cloud. It also makes sure that users with incomplete profiles (like those who have not finished onboarding) have the alert show up as well.
Summary generated by Copilot
🤖 Generated by Copilot at 0e0c360
Improved dashboard notifications for self-hosted and gitpod.io users. Refactored
AppNotifications.tsxto reorder imports and limit privacy policy notification togitpod.iodomain.Related Issue(s)
Fixes #
How to test
If you inspect the WebSocket connection on the Dashboard, the first request should be for getting the logged-in user. If you take a look at the response, there should be a
acceptedPrivacyPolicyDateunderadditionalData.profile. Make sure it's there and that the alert is not showing up because of the auto-accept during login.Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled.