Fix ?until in BBS commit contexts
#18987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into this now... |
AlexTugarev
reviewed
Oct 31, 2023
components/server/src/bitbucket-server/bitbucket-server-context-parser.spec.ts
Outdated
Show resolved
Hide resolved
|
It's be best to test that first. Code wise it looks fine. To recap: BBS has the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Bitbucket server, the commits view works a bit differently than on https://bitbucket.org. Instead of containing the concerned branch name in the URL path, it is stored in the
untilsearch parameter. We did not account for that.Summary generated by Copilot
🤖 Generated by Copilot at 72bc2b0
This pull request enhances the
BitbucketServerContextParserclass and its tests to support commit context URLs with branch names. This allows users to open Gitpod workspaces from such URLs and see the correct branch and commit information.Related Issue(s)
Fixes EXP-844
Preview status
Gitpod was successfully deployed to your preview environment.
How to test
I had to do some code gymnastics to get the tests working properly with our BBS instance, but here they run, successfully.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold