Skip to content

Fix normalized case-sensitive search params #18992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Nov 1, 2023

Description

Contexts with case-sensitive parts of their URLs would get lowercased and hence potentially invalidated. This was the case for some Bitbucket Server contexts with branch names as part of their search queries.

Summary generated by Copilot

🤖 Generated by Copilot at 114b77f

Removed toLowerCase call from unified repositories search feature to respect case-sensitive search operators. This fixes issue #5210 and affects the file unified-repositories-search-query.ts.

Related Issue(s)

Fixes EXP-857

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@filiptronicek
Copy link
Member Author


image

@selfcontained
Copy link
Contributor

/gh run

@roboquat roboquat merged commit 35b4d6a into main Nov 2, 2023
@roboquat roboquat deleted the ft/fix-case-sensitive-search-params branch November 2, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants