[a11y] Add dark mode support to InputWithCopy and TextInputField components
#19011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextInputField components
svenefftinge
reviewed
Nov 5, 2023
| @@ -97,7 +97,7 @@ export const TextInput: FunctionComponent<TextInputProps> = memo( | |||
| return ( | |||
| <input | |||
| id={id} | |||
| className={classNames("w-full max-w-lg", className)} | |||
| className={classNames("w-full max-w-lg dark:text-[#A8A29E]", className)} | |||
There was a problem hiding this comment.
- can we use a color that we use elsewhere?
- would this not be dependent on the
disabledstate?
There was a problem hiding this comment.
can we use a color that we use elsewhere?
I used the SVG color of Copy icon.
can we use a color that we use elsewhere?
would this not be dependent on the disabled state?
Looks good to me, that both of the text is readable:
svenefftinge
approved these changes
Nov 5, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Text inside disabled modal is more readable now in dark mode.
Summary generated by Copilot
🤖 Generated by Copilot at 080cfa3
Improve text contrast and readability of
TextInputcomponents in dark mode. Apply a dark text color toTextInputincomponents/dashboard/src/components/forms/TextInputField.tsxandcomponents/dashboard/src/components/InputWithCopy.tsx.Related Issue(s)
Fixes internal conversation
How to test
More Actions...& then click onConnect via SSHand see SSH command is more readable now 👀Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold