[dashboard] deduplicate repositories #19013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/dedupe-repos
branch
from
2ee6854 to
46f1d61
Compare
svenefftinge
commented
Nov 5, 2023
components/server/src/bitbucket-server/bitbucket-server-repository-provider.ts
Show resolved
Hide resolved
filiptronicek
approved these changes
Nov 5, 2023
components/dashboard/src/data/git-providers/unified-repositories-search-query.test.ts
Outdated
Show resolved
Hide resolved
components/dashboard/src/data/git-providers/unified-repositories-search-query.ts
Show resolved
Hide resolved
components/dashboard/src/data/git-providers/unified-repositories-search-query.ts
Outdated
Show resolved
Hide resolved
svenefftinge
force-pushed
the
se/dedupe-repos
branch
from
21db402 to
0f2c496
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug with the repository search query, so that duplicates get filtered out properly.
Before this change I would see two entries for a repo if I were adding a project for a repo.
After this change you only see the one that contains the project.
Summary generated by Copilot
🤖 Generated by Copilot at 2ee6854
This pull request improves the unified repository search feature for the dashboard component, by simplifying and testing the hook and function that filter repositories from different git providers. It also increases the limit of results returned by the Bitbucket Server provider in the server component, to match the other providers and provide more options.
Related Issue(s)
Fixes EXP-869
How to test
Add a project for a repo and verify that the repo is not listed twice in the create workspace page.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold