Revert service-waiter (components) for dashboard #19026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustard-mh
force-pushed
the
hw/revert-waiter
branch
from
f2f3aa5 to
0aa8eec
Compare
mustard-mh
changed the title
akosyakov
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@mustard-mh pre approved, but please check start of preview envs once please
|
How do we test this on a preview env? |
|
|
double checked there's not initContainer in deploy/dashboard @laushinka Feel free to unhold if you test it right if you want |
|
I tested already rollouts, let's unhold. |
It's ok, you've both tested it 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #18995
Until we have way to control skip service-waiter (like feature flag)
See also internal chat
Summary generated by Copilot
🤖 Generated by Copilot at f2f3aa5
Refactor the installer and the service-waiter components to improve security, readability, maintainability, and scalability. Remove unused dependencies and code, use a cluster role and a pod security policy for the dashboard component, and replace the init containers with the service-waiter component. Delete
components/service-waiter/cmd/component.goandinstall/installer/pkg/components/dashboard/role.goas they are no longer needed.Related Issue(s)
Fixes #
How to test
kubectl describe pod dashboard-...check that there are not any more any init containers + dashboard deployed without issuesDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold