Improve log level printing #19030
Merged
Improve log level printing #19030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
approved these changes
Nov 7, 2023
| case slog.LevelDebug.String(): | ||
| attr.Value = slog.StringValue(color.Gray.Render("[DEBUG]")) | ||
| case slog.LevelInfo.String(): | ||
| attr.Value = slog.StringValue(color.Green.Render("[INFO ]")) |
There was a problem hiding this comment.
Good that we're keeping the indentation of the messages consistent with this, although it may be a bit confusing for grepping output
There was a problem hiding this comment.
It also looks a bit odd if there isn't any output that actually aligns here.
Let's run with it for now and change it if it's too odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at ce98fdc
Improve local-app logging output and add color option. This pull request adds a
--no-colorflag to the local-app command to disable colored output, and uses different colors for different log levels to make them easier to distinguish.Related Issue(s)
Fixes EXP-888
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold