Skip to content

local cli: support additional ssh arguments #19046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2023
Merged

local cli: support additional ssh arguments #19046

merged 4 commits into from
Nov 10, 2023

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Nov 9, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 025d64b

Add support for passing additional arguments to SSH command in gitpod workspace ssh and remove unused dependency from local-app module. This improves the usability and maintainability of the gitpod CLI tool.

Related Issue(s)

Fixes EXP-902

How to test

  • Open Gitpod with this PR
  • Exec commands
leeway run components/local-app:install-cli
leeway run components/local-app:cli-completion

gitpod login --token <you_pat_token>
gitpod ws ssh $(gp info --json | jq -r .workspace_id) -- cat /workspace/gitpod/components/local-app/cmd/workspace-ssh.go

‼️ Case like echo 'echo hello' | gitpod ws ssh gitpodio-gitpod-er1bcypgceo cat is not covert, let's ignore it first ()

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh mustard-mh requested a review from akosyakov November 9, 2023 10:12
$ gitpod ws ssh <workspace-id> -- -t watch date

# Get all SSH features with --dry-run
$ $(gitpod workspace ssh <workspace-id> --dry-run) -- ls -la
Copy link
Member

@akosyakov akosyakov Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still think we should remove it, wait for bugs, and fix them properly, not spread hacks.

@roboquat roboquat merged commit c4354f0 into main Nov 10, 2023
@roboquat roboquat deleted the hw/cli-ssh branch November 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants