Skip to content

[usage] export creation and stopped time #19047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[usage] export creation and stopped time #19047

merged 1 commit into from
Nov 9, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Nov 9, 2023

Description

This PR exports the creationTime and the stoppedTime in addition to the already exported startedTime and the stoppingTime . It only does that for new workspace sessions happening after this change landed.

Summary generated by Copilot

🤖 Generated by Copilot at 1e98d4a

This pull request adds creation and stop times to the workspace instance usage data and CSV export. It updates the Go and TypeScript types and interfaces, as well as the CSV generation logic, to include these new fields. The goal is to provide more insight into the workspace instance lifecycle for users and admins.

Related Issue(s)

Fixes EXP-904

How to test

Join my org and check the usage export. it should have stoppedTime and creationTime exported with reasonable values.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

  • 🏷️ Name - se-add-usage-data
  • 🔗 URL - se-add-usage-data.preview.gitpod-dev.com/workspaces.
  • 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
  • 📦 Version -
  • 🗒️ Logs - GCP Logs Explorer
  • Build Options

    Build
    • /werft with-werft
      Run the build with werft instead of GHA
    • leeway-no-cache
    • /werft no-test
      Run Leeway with --dont-test
    Publish
    • /werft publish-to-npm
    • /werft publish-to-jb-marketplace
    Installer
    • analytics=segment
    • with-dedicated-emulation
    • workspace-feature-flags
      Add desired feature flags to the end of the line above, space separated
    Preview Environment / Integration Tests
    • /werft with-local-preview
      If enabled this will build install/preview
    • /werft with-preview
    • /werft with-large-vm
    • /werft with-gce-vm
      If enabled this will create the environment on GCE infra
    • with-integration-tests=all
      Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
    • with-monitoring

    /hold

@akosyakov
Copy link
Member

@svenefftinge is it ok that I don't see my workspaces here, but in report?
Screenshot 2023-11-09 at 13 37 51

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see new attributes in reporting. UI does not reflect my workspace though, but this PR does not touch UI code.

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Nov 9, 2023

is it ok that I don't see my workspaces here, but in report?

I assume your usage was not reconciled yet.

@akosyakov
Copy link
Member

akosyakov commented Nov 9, 2023

@svenefftinge does it mean that UI and CSV report are using different source?

@svenefftinge
Copy link
Contributor Author

@svenefftinge does it mean that UI and CSV report are using different source?

It is the same source. If you saw it in the export you should also see it in the UI (after reload)

@akosyakov
Copy link
Member

ok, I see it now. Probably I did not reload, let's merge.

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 4de3805 into main Nov 9, 2023
@roboquat roboquat deleted the se/add-usage-data branch November 9, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants