Skip to content

Add test for ObserveWorkspaceUntilStarted #19050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add test for ObserveWorkspaceUntilStarted #19050

merged 1 commit into from
Nov 10, 2023

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Nov 9, 2023

Description

Adds basic tests for ObserveWorkspaceUntilStarted.

Summary generated by Copilot

🤖 Generated by Copilot at c44515c

This pull request enhances the local app component by refactoring and testing the ObserveWorkspaceUntilStarted function. It fixes a bug, adds a status check, simplifies the logic, and improves the error handling of the function. It also adds a new file workspace_test.go that contains unit tests for the function.

How to test

See unit tests

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@akosyakov
Copy link
Member

I did not try, but to unlbock.

@roboquat roboquat merged commit f48c854 into main Nov 10, 2023
@roboquat roboquat deleted the cw/cli-tests branch November 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants