-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Gitpod CLI: Improve Segment logging #19064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If I'm a user, I don't care any respond / process for metrics / telemetry / error report () even in Maybe add another level |
@mustard-mh fair enough, it maybe should be a different level altogether. Looping in @csweichel, any advice for telemetry logs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works, ✔️ to unblock.
I like @mustard-mh suggestion to push it down to trace, but silencing it entirely is also fine I think. Leaving it to @filiptronicek to force the discussion here, to move it to a follow-up PR. 🧘
While we are in preview, I will leave segment errors in verbose output. It would be great to add another logging level, but that adds some complexity, both technical and user-facing (we have I also fixed auto-updating by properly proxying the manifest file. |
Description
Only enables Segment logging when logging verbose output. It means that Segment errors do not get outputted to standard error, because it is not critical to the CLI's functionality.
Summary generated by Copilot
🤖 Generated by Copilot at 91af8d6
Add custom logger for telemetry package and expose log level option to user. This improves the visibility and control of the telemetry output in the local-app component.
Related Issue(s)
Fixes EXP-912
How to test
Personally, I tested by changing the client configuration of Segment to some bogus address.
In the first command, the error is not shown. In the second one, we use verbose output and therefore it is.

Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold