[server] remove obsolete and unused getSuggestedContextURLs
#19074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Thanks for cleaning up 🙏.
We are using the method in the desktop app, but think it's safe to ignore now.
cc @selfcontained
@filiptronicek, thanks for pointing this out. I think in the gRPC-based API there will be equivalent methods available, as they are already used by the Dashboard. 🙏🏻 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The json-rpc method
getSuggestedContextURLsis unused for quite a while now.Summary generated by Copilot
🤖 Generated by Copilot at 866c80d
This pull request removes the deprecated
getSuggestedContextURLsmethod and its related code from the Gitpod service interface, the public API server, the dashboard, and the tests. This method was replaced by thegetAccessibleProjectsmethod, which provides a better user experience for selecting repositories to start workspaces from.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold