Skip to content

[ts] Add metric gitpod_logs_total(level) for TS components #19093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Nov 20, 2023

Description

Based on: #19063

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at caf9b1a

This pull request improves the logging functionality and adds log count reporting to the server and ws-manager-bridge components. It introduces a new file logging-backend.ts that defines a function to report log counts to Prometheus, and uses this function in the init.ts and main.ts files of the respective components.

Related Issue(s)

Fixes ENG-349

How to test

  • kubectl port-forward deployment/server 9500 &
  • curl localhost:9500/metrics | grep logs_total
  • interact with the system, and repeat the query to see the metrics increasing ✔️

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl marked this pull request as ready for review November 21, 2023 08:57
@geropl geropl requested a review from a team as a code owner November 21, 2023 08:57
@geropl geropl marked this pull request as draft November 21, 2023 08:57
@geropl geropl force-pushed the gpl/ts-log-metrics branch from caf9b1a to 5641a7a Compare November 21, 2023 09:26
Base automatically changed from mp/baseserver-log-metrics to main November 21, 2023 10:27
@roboquat roboquat added size/L and removed size/M labels Nov 21, 2023
@easyCZ
Copy link
Member

easyCZ commented Nov 21, 2023

Parent PR has landed

@geropl geropl force-pushed the gpl/ts-log-metrics branch from 5641a7a to a96aaa4 Compare November 21, 2023 12:40
@roboquat roboquat added size/M and removed size/L labels Nov 21, 2023
@geropl geropl marked this pull request as ready for review November 21, 2023 12:43
@geropl
Copy link
Member Author

geropl commented Nov 21, 2023

Rebased on main and pushed.

@geropl
Copy link
Member Author

geropl commented Nov 21, 2023

/unhold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to unblock

I have not tried, but code changes look reasonable.

@roboquat roboquat merged commit 9be1fec into main Nov 21, 2023
@roboquat roboquat deleted the gpl/ts-log-metrics branch November 21, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants