Skip to content

[server] fix listAuthProviderDescriptions if unauthenticated #19094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Nov 20, 2023

Description

This is a follow-up from https://github.com/gitpod-io/gitpod/pull/19023/files#r1399425814

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 84116e8

Add authorization checks to auth provider service API. Use request-context module to get caller identity and context.

Related Issue(s)

Fixes #

How to test

  • enable FF for gRPC in server
  • see that the Login page is rendered properly

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM 👍

@AlexTugarev AlexTugarev force-pushed the at/fix-list-providers-unauthenticated branch from 84116e8 to 777d095 Compare November 21, 2023 07:31
@AlexTugarev
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 64852fa into main Nov 21, 2023
@roboquat roboquat deleted the at/fix-list-providers-unauthenticated branch November 21, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants